Provide clean API for passing watchdog function. #182

aentinger · 2021-06-07T07:31:10Z

Instead of relying on the 'hidden mechanism' of passing a function to feed the watchdog via a weak function definition pass a function pointer via a public API instead. This increases visibility and reduces unintentional introductions of bugs.

… feed the watchdog via a weak function definition pass a function pointer via a public API instead. This increases visibility and reduces unintentional introductions of bugs.

Requires arduino-libraries/WiFiNINA#182.

github-actions · 2021-06-07T08:10:15Z

Memory usage change @ 2ab2a4b

Board	flash	%	RAM for global variables	%
arduino:mbed_nano:nanorp2040connect	🔺 0 - +24	0.0 - 0.0	🔺 0 - +4	0.0 - 0.0
arduino:megaavr:uno2018:mode=on	🔺 0 - +70	0.0 - +0.14	🔺 0 - +2	0.0 - +0.03
arduino:samd:mkrvidor4000	🔺 0 - +24	0.0 - +0.01	🔺 0 - +4	0.0 - +0.01
arduino:samd:mkrwifi1010	🔺 0 - +24	0.0 - +0.01	🔺 0 - +4	0.0 - +0.01
arduino:samd:nano_33_iot	🔺 0 - +24	0.0 - +0.01	🔺 0 - +4	0.0 - +0.01

Click for full report table

Board	examples/AP_SimpleWebServer flash	%	examples/AP_SimpleWebServer RAM for global variables	%	examples/ConnectNoEncryption flash	%	examples/ConnectNoEncryption RAM for global variables	%	examples/ConnectWithWEP flash	%	examples/ConnectWithWEP RAM for global variables	%	examples/ConnectWithWPA flash	%	examples/ConnectWithWPA RAM for global variables	%	examples/ConnectWithWPA2Enterprise flash	%	examples/ConnectWithWPA2Enterprise RAM for global variables	%	examples/ScanNetworks flash	%	examples/ScanNetworks RAM for global variables	%	examples/ScanNetworksAdvanced flash	%	examples/ScanNetworksAdvanced RAM for global variables	%	examples/SimpleWebServerWiFi flash	%	examples/SimpleWebServerWiFi RAM for global variables	%	examples/Tools/CheckFirmwareVersion flash	%	examples/Tools/CheckFirmwareVersion RAM for global variables	%	examples/WiFiChatServer flash	%	examples/WiFiChatServer RAM for global variables	%	examples/WiFiPing flash	%	examples/WiFiPing RAM for global variables	%	examples/WiFiSSLClient flash	%	examples/WiFiSSLClient RAM for global variables	%	examples/WiFiStorage flash	%	examples/WiFiStorage RAM for global variables	%	examples/WiFiUdpNtpClient flash	%	examples/WiFiUdpNtpClient RAM for global variables	%	examples/WiFiUdpSendReceiveString flash	%	examples/WiFiUdpSendReceiveString RAM for global variables	%	examples/WiFiWebClient flash	%	examples/WiFiWebClient RAM for global variables	%	examples/WiFiWebClientRepeating flash	%	examples/WiFiWebClientRepeating RAM for global variables	%	examples/WiFiWebServer flash	%	examples/WiFiWebServer RAM for global variables	%
arduino:mbed_nano:nanorp2040connect	16	0.0	4	0.0	24	0.0	4	0.0	24	0.0	4	0.0	16	0.0	4	0.0	16	0.0	4	0.0	16	0.0	4	0.0	16	0.0	4	0.0	24	0.0	4	0.0	16	0.0	4	0.0	24	0.0	4	0.0	24	0.0	4	0.0	16	0.0	4	0.0	16	0.0	4	0.0	24	0.0	4	0.0	16	0.0	4	0.0	24	0.0	4	0.0	16	0.0	4	0.0	24	0.0	4	0.0
arduino:megaavr:uno2018:mode=on	56	0.12	2	0.03	14	0.03	2	0.03	14	0.03	2	0.03	14	0.03	2	0.03	0	0.0	2	0.03	0	0.0	2	0.03	0	0.0	2	0.03	70	0.14	2	0.03	0	0.0	2	0.03	70	0.14	2	0.03	14	0.03	2	0.03	70	0.14	2	0.03	0	0.0	2	0.03	14	0.03	2	0.03	14	0.03	2	0.03	70	0.14	2	0.03	70	0.14	2	0.03	70	0.14	2	0.03
arduino:samd:mkrvidor4000	16	0.01	4	0.01	24	0.01	4	0.01	24	0.01	4	0.01	20	0.01	4	0.01	16	0.01	4	0.01	16	0.01	4	0.01	16	0.01	4	0.01	20	0.01	4	0.01	16	0.01	4	0.01	20	0.01	4	0.01	24	0.01	4	0.01	20	0.01	4	0.01	16	0.01	4	0.01	20	0.01	4	0.01	20	0.01	4	0.01	20	0.01	4	0.01	20	0.01	4	0.01	20	0.01	4	0.01
arduino:samd:mkrwifi1010	16	0.01	4	0.01	24	0.01	4	0.01	24	0.01	4	0.01	20	0.01	4	0.01	16	0.01	4	0.01	16	0.01	4	0.01	16	0.01	4	0.01	20	0.01	4	0.01	16	0.01	4	0.01	20	0.01	4	0.01	24	0.01	4	0.01	20	0.01	4	0.01	16	0.01	4	0.01	20	0.01	4	0.01	20	0.01	4	0.01	20	0.01	4	0.01	20	0.01	4	0.01	20	0.01	4	0.01
arduino:samd:nano_33_iot	16	0.01	4	0.01	24	0.01	4	0.01	24	0.01	4	0.01	20	0.01	4	0.01	16	0.01	4	0.01	16	0.01	4	0.01	16	0.01	4	0.01	20	0.01	4	0.01	16	0.01	4	0.01	20	0.01	4	0.01	24	0.01	4	0.01	20	0.01	4	0.01	16	0.01	4	0.01	20	0.01	4	0.01	20	0.01	4	0.01	20	0.01	4	0.01	20	0.01	4	0.01	20	0.01	4	0.01

Click for full report CSV

Board,examples/AP_SimpleWebServer<br>flash,%,examples/AP_SimpleWebServer<br>RAM for global variables,%,examples/ConnectNoEncryption<br>flash,%,examples/ConnectNoEncryption<br>RAM for global variables,%,examples/ConnectWithWEP<br>flash,%,examples/ConnectWithWEP<br>RAM for global variables,%,examples/ConnectWithWPA<br>flash,%,examples/ConnectWithWPA<br>RAM for global variables,%,examples/ConnectWithWPA2Enterprise<br>flash,%,examples/ConnectWithWPA2Enterprise<br>RAM for global variables,%,examples/ScanNetworks<br>flash,%,examples/ScanNetworks<br>RAM for global variables,%,examples/ScanNetworksAdvanced<br>flash,%,examples/ScanNetworksAdvanced<br>RAM for global variables,%,examples/SimpleWebServerWiFi<br>flash,%,examples/SimpleWebServerWiFi<br>RAM for global variables,%,examples/Tools/CheckFirmwareVersion<br>flash,%,examples/Tools/CheckFirmwareVersion<br>RAM for global variables,%,examples/Tools/FirmwareUpdater<br>flash,%,examples/Tools/FirmwareUpdater<br>RAM for global variables,%,examples/Tools/SerialNINAPassthrough<br>flash,%,examples/Tools/SerialNINAPassthrough<br>RAM for global variables,%,examples/WiFiChatServer<br>flash,%,examples/WiFiChatServer<br>RAM for global variables,%,examples/WiFiPing<br>flash,%,examples/WiFiPing<br>RAM for global variables,%,examples/WiFiSSLClient<br>flash,%,examples/WiFiSSLClient<br>RAM for global variables,%,examples/WiFiStorage<br>flash,%,examples/WiFiStorage<br>RAM for global variables,%,examples/WiFiUdpNtpClient<br>flash,%,examples/WiFiUdpNtpClient<br>RAM for global variables,%,examples/WiFiUdpSendReceiveString<br>flash,%,examples/WiFiUdpSendReceiveString<br>RAM for global variables,%,examples/WiFiWebClient<br>flash,%,examples/WiFiWebClient<br>RAM for global variables,%,examples/WiFiWebClientRepeating<br>flash,%,examples/WiFiWebClientRepeating<br>RAM for global variables,%,examples/WiFiWebServer<br>flash,%,examples/WiFiWebServer<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,16,0.0,4,0.0,24,0.0,4,0.0,24,0.0,4,0.0,16,0.0,4,0.0,16,0.0,4,0.0,16,0.0,4,0.0,16,0.0,4,0.0,24,0.0,4,0.0,16,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,24,0.0,4,0.0,24,0.0,4,0.0,16,0.0,4,0.0,16,0.0,4,0.0,24,0.0,4,0.0,16,0.0,4,0.0,24,0.0,4,0.0,16,0.0,4,0.0,24,0.0,4,0.0
arduino:megaavr:uno2018:mode=on,56,0.12,2,0.03,14,0.03,2,0.03,14,0.03,2,0.03,14,0.03,2,0.03,0,0.0,2,0.03,0,0.0,2,0.03,0,0.0,2,0.03,70,0.14,2,0.03,0,0.0,2,0.03,0,0.0,0,0.0,0,0.0,0,0.0,70,0.14,2,0.03,14,0.03,2,0.03,70,0.14,2,0.03,0,0.0,2,0.03,14,0.03,2,0.03,14,0.03,2,0.03,70,0.14,2,0.03,70,0.14,2,0.03,70,0.14,2,0.03
arduino:samd:mkrvidor4000,16,0.01,4,0.01,24,0.01,4,0.01,24,0.01,4,0.01,20,0.01,4,0.01,16,0.01,4,0.01,16,0.01,4,0.01,16,0.01,4,0.01,20,0.01,4,0.01,16,0.01,4,0.01,0,0.0,0,0.0,0,0.0,0,0.0,20,0.01,4,0.01,24,0.01,4,0.01,20,0.01,4,0.01,16,0.01,4,0.01,20,0.01,4,0.01,20,0.01,4,0.01,20,0.01,4,0.01,20,0.01,4,0.01,20,0.01,4,0.01
arduino:samd:mkrwifi1010,16,0.01,4,0.01,24,0.01,4,0.01,24,0.01,4,0.01,20,0.01,4,0.01,16,0.01,4,0.01,16,0.01,4,0.01,16,0.01,4,0.01,20,0.01,4,0.01,16,0.01,4,0.01,0,0.0,0,0.0,0,0.0,0,0.0,20,0.01,4,0.01,24,0.01,4,0.01,20,0.01,4,0.01,16,0.01,4,0.01,20,0.01,4,0.01,20,0.01,4,0.01,20,0.01,4,0.01,20,0.01,4,0.01,20,0.01,4,0.01
arduino:samd:nano_33_iot,16,0.01,4,0.01,24,0.01,4,0.01,24,0.01,4,0.01,20,0.01,4,0.01,16,0.01,4,0.01,16,0.01,4,0.01,16,0.01,4,0.01,20,0.01,4,0.01,16,0.01,4,0.01,0,0.0,0,0.0,0,0.0,0,0.0,20,0.01,4,0.01,24,0.01,4,0.01,20,0.01,4,0.01,16,0.01,4,0.01,20,0.01,4,0.01,20,0.01,4,0.01,20,0.01,4,0.01,20,0.01,4,0.01,20,0.01,4,0.01

Instead of relying on the 'hidden mechanism' of passing a function to…

2ab2a4b

… feed the watchdog via a weak function definition pass a function pointer via a public API instead. This increases visibility and reduces unintentional introductions of bugs.

aentinger added the type: enhancement Proposed improvement label Jun 7, 2021

aentinger self-assigned this Jun 7, 2021

aentinger added a commit to arduino-libraries/ArduinoIoTCloud that referenced this pull request Jun 7, 2021

Pass function for feeding the watchdog via public API.

cd04eef

Requires arduino-libraries/WiFiNINA#182.

aentinger mentioned this pull request Jun 7, 2021

INITIAL: support OTA on Nano RP2040 Connect arduino-libraries/ArduinoIoTCloud#256

Merged

aentinger closed this Jun 7, 2021

aentinger deleted the pass-watchdog-func-via-api branch June 7, 2021 11:27

aentinger restored the pass-watchdog-func-via-api branch June 10, 2021 07:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Provide clean API for passing watchdog function. #182

Provide clean API for passing watchdog function. #182

Uh oh!

aentinger commented Jun 7, 2021

Uh oh!

github-actions bot commented Jun 7, 2021

Uh oh!

Uh oh!

Provide clean API for passing watchdog function. #182

Provide clean API for passing watchdog function. #182

Uh oh!

Conversation

aentinger commented Jun 7, 2021

Uh oh!

github-actions bot commented Jun 7, 2021

Uh oh!

Uh oh!